On Thu, Jan 23, 2020 at 12:37:35PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id > and using MachineState::ram instead of manually initializing > RAM memory region. > > PS: > While at it, get rid of no longer needed CubieBoardState wrapper. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > --- > CC: drjo...@redhat.com > CC: b.galv...@gmail.com > CC: peter.mayd...@linaro.org > CC: qemu-...@nongnu.org > --- > hw/arm/cubieboard.c | 25 ++++++++----------------- > 1 file changed, 8 insertions(+), 17 deletions(-) >
I don't know anything about cubieboard, but I promised Igor to put another pair of eyes on his changes. Looks fine to me. Reviewed-by: Andrew Jones <drjo...@redhat.com>
