On Mon, Jun 6, 2011 at 5:17 PM, Luiz Capitulino <lcapitul...@redhat.com> wrote: > On Sat, 4 Jun 2011 11:34:17 +0300 > Blue Swirl <blauwir...@gmail.com> wrote: > >> On Wed, Jun 1, 2011 at 6:54 PM, Luiz Capitulino <lcapitul...@redhat.com> >> wrote: >> > From: Lai Jiangshan <la...@cn.fujitsu.com> >> > >> > inject-nmi command injects an NMI on all CPUs of guest. >> > It is only supported for x86 guest currently, it will >> > returns "Unsupported" error for non-x86 guest. >> >> Please rename the command to 'x-inject-nmi' to point out that it will >> be replaced by a generic method later. > > Won't the generic interface be called 'inject'? In that case calling this > command 'inject-nmi' makes sense as it's exactly what the command does and > in the future it can be written in terms of the new 'inject' command.
This is a bit useless since the patch was committed, but I was pointed out that 'inject' wasn't so great name, 'raise/lower/pulse' should have been more precise. But I guess we can live with yet another poor interface, so who cares what the name is.
