On 21/01/2020 22.38, Philippe Mathieu-Daudé wrote: > Missed in 870c034da0b, hopefully reported by Coverity. > > Fixes: Coverity CID 1412793 (Incorrect expression) > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/misc/stm32f4xx_syscfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c > index dbcdca59f8..f960e4ea1e 100644 > --- a/hw/misc/stm32f4xx_syscfg.c > +++ b/hw/misc/stm32f4xx_syscfg.c > @@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, > int level) > STM32F4xxSyscfgState *s = opaque; > int icrreg = irq / 4; > int startbit = (irq & 3) * 4; > - uint8_t config = config = irq / 16; > + uint8_t config = irq / 16; > > trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level); > >
Reviewed-by: Thomas Huth <th...@redhat.com>
