On Tue, Jan 21, 2020 at 11:05 PM Jonathan Behrens <jonat...@fintelia.io> wrote: > > I was just doubling checking the status of this patch because it conflicts > with the "RISC-V TIME CSR for privileged mode" PR that was just sent out, and > it seems this never got merged? In any case, perhaps these changes should be > rolled into that patch?
I think this should be merged first. @Palmer Dabbelt can you merge this? Alistair > > On Wed, Aug 21, 2019 at 1:37 PM Palmer Dabbelt <pal...@sifive.com> wrote: >> >> On Wed, 14 Aug 2019 20:19:39 PDT (-0700), jonat...@fintelia.io wrote: >> > Ping! What is the status of this patch? >> >> Sorry, I must have lost track of it. I've added it to my patch queue. >> >> > >> > On Wed, Jul 3, 2019 at 2:02 PM Jonathan Behrens <jonat...@fintelia.io> >> > wrote: >> > >> >> Bin, that proposal proved to be somewhat more controversial than I was >> >> expecting, since it was different than how currently available hardware >> >> worked. This option seemed much more likely to be accepted in the short >> >> term. >> >> >> >> Jonathan >> >> >> >> On Mon, Jul 1, 2019 at 9:26 PM Bin Meng <bmeng...@gmail.com> wrote: >> >> >> >>> On Tue, Jul 2, 2019 at 8:20 AM Alistair Francis <alistai...@gmail.com> >> >>> wrote: >> >>> > >> >>> > On Mon, Jul 1, 2019 at 8:56 AM <jonat...@fintelia.io> wrote: >> >>> > > >> >>> > > From: Jonathan Behrens <jonat...@fintelia.io> >> >>> > > >> >>> > > QEMU currently always triggers an illegal instruction exception when >> >>> > > code attempts to read the time CSR. This is valid behavor, but only >> >>> > > if >> >>> > > the TM bit in mcounteren is hardwired to zero. This change also >> >>> > > corrects mcounteren and scounteren CSRs to be 32-bits on both 32-bit >> >>> > > and 64-bit targets. >> >>> > > >> >>> > > Signed-off-by: Jonathan Behrens <jonat...@fintelia.io> >> >>> > >> >>> > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> >> >>> > >> >>> >> >>> I am a little bit lost here. I think we agreed to allow directly read >> >>> to time CSR when mcounteren.TM is set, no? >> >>> >> >>> Regards, >> >>> Bin >> >>> >> >>
