On Mon, 20 Jan 2020 14:24:41 +0100 Thomas Huth <th...@redhat.com> wrote:
> The AIS feature has been disabled late in the v2.10 development cycle since > there were some issues with migration (see commit 3f2d07b3b01ea61126b - > "s390x/ais: for 2.10 stable: disable ais facility"). We originally wanted > to enable it again for newer machine types, but apparently we forgot to do > this so far. Let's do it for the new s390-ccw-virtio-5.0 machine now. > > While at it, also add a more verbose comment why we need the *_allowed() > wrappers in s390-virtio-ccw.c. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1756946 > Reviewed-by: David Hildenbrand <da...@redhat.com> > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > v3: Moved "s390mc->kvm_ais_allowed = false" to the end of the function We also might want to move the others in a followup patch, just to avoid bad examples to copy/paste. > > hw/s390x/s390-virtio-ccw.c | 20 +++++++++++++++++--- > include/hw/s390x/s390-virtio-ccw.h | 3 +++ > target/s390x/kvm.c | 9 ++++++--- > 3 files changed, 26 insertions(+), 6 deletions(-) Looks good to me, will queue when I get a positive test result.
