On 1/20/20 5:35 AM, Peter Maydell wrote:
On Sat, 18 Jan 2020 at 16:42, Guenter Roeck <li...@roeck-us.net> wrote:
[ ... ]
v2: Use interrupt combiner instead of connecting all events to a single interrupt. Limit number of events per DMA channel to 31 to meet qemu interrupt combiner limitations. [Not sure if "assert(s->num_lines < MAX_OR_LINES);" should be "assert(s->num_lines <= MAX_OR_LINES);"]Yes, that looks like a bug in or-irq.c -- it should be using <=, so 32 is permissible. As the comment in or-irq.h notes, we can safely simply bump the #define value without breaking anything if you need more input OR lines than 32.
Yes, I noticed the comment, and I did that initially, but then I noticed the complexity of actually doing it in the code increasing it from 16 to 32, and decided I better leave it alone. I'll add another patch fixing the check and use 32.
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Thanks, Guenter
