Re: [PATCH 21/86] arm:kzm: use memdev for RAM

[Philippe Mathieu-Daudé]

On 12/31/19 2:03 PM, Igor Mammedov wrote:

memory_region_allocate_system_memory() API is going away, so
replace it with memdev allocated MemoryRegion. The later is
initialized by generic code, so board only needs to opt in
to memdev scheme by providing
   MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing
RAM memory region.

Signed-off-by: Igor Mammedov <imamm...@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>

---
  hw/arm/kzm.c | 9 ++++-----
  1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/hw/arm/kzm.c b/hw/arm/kzm.c
index 27800c5..f63902e 100644
--- a/hw/arm/kzm.c
+++ b/hw/arm/kzm.c
@@ -51,7 +51,6 @@

typedef struct IMX31KZM {

      FslIMX31State soc;
-    MemoryRegion ram;
      MemoryRegion ram_alias;
  } IMX31KZM;

@@ -84,10 +83,8 @@ static void kzm_init(MachineState *machine)

          exit(EXIT_FAILURE);
      }

- memory_region_allocate_system_memory(&s->ram, NULL, "kzm.ram",

-                                         machine->ram_size);
      memory_region_add_subregion(get_system_memory(), FSL_IMX31_SDRAM0_ADDR,
-                                &s->ram);
+                                machine->ram);

/* initialize the alias memory if any */

      for (i = 0, ram_size = machine->ram_size, alias_offset = 0;
@@ -107,7 +104,8 @@ static void kzm_init(MachineState *machine)

if (size < ram[i].size) {

              memory_region_init_alias(&s->ram_alias, NULL, "ram.alias",
-                                     &s->ram, alias_offset, ram[i].size - 
size);
+                                     machine->ram,
+                                     alias_offset, ram[i].size - size);
              memory_region_add_subregion(get_system_memory(),
                                          ram[i].addr + size, &s->ram_alias);
          }
@@ -139,6 +137,7 @@ static void kzm_machine_init(MachineClass *mc)
      mc->desc = "ARM KZM Emulation Baseboard (ARM1136)";
      mc->init = kzm_init;
      mc->ignore_memory_transaction_failures = true;
+    mc->default_ram_id = "kzm.ram";
  }

DEFINE_MACHINE("kzm", kzm_machine_init)