"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> Test that this sequerce works:
>> + /* 1 ms should make it not converge*/
>> + migrate_set_parameter_int(from, "downtime-limit", 1);
>> + /* 1GB/s */
>> + migrate_set_parameter_int(from, "max-bandwidth", 1000000000);
>
> This is copied from postcopy_prepare, note that I dropped that bandwidth
> quite a bit in 513aa2c because we were seeing TCG on slow hosts converge
> even at 1ms, because the vCPU wasn't dirtying pages quickly.
>
We have to use a #define to have everything using the same. Right now,
I am using the same that preoopy_tcp and that multifd :-(
>> + migrate_set_parameter_int(from, "multifd-channels", 16);
>> + migrate_set_parameter_int(to, "multifd-channels", 16);
>> +
>> + migrate_set_capability(from, "multifd", "true");
>> + migrate_set_capability(to, "multifd", "true");
>> +
>> + /* Start incoming migration from the 1st socket */
>> + rsp = wait_command(to, "{ 'execute': 'migrate-incoming',"
>> + " 'arguments': { 'uri': 'tcp:127.0.0.1:0' }}");
>> + qobject_unref(rsp);
>> +
>> + /* Wait for the first serial output from the source */
>> + wait_for_serial("src_serial");
>> +
>> + uri = migrate_get_socket_address(to, "socket-address");
>> +
>> + migrate(from, uri, "{}");
>> +
>> + wait_for_migration_pass(from);
>> +
>> + printf("before cancel\n");
>> + migrate_cancel(from);
>> + printf("after cancel\n");
>
> Do you really want those printf's for normal operation?
Obviously no, thanks.
>> +
>> + /* 300ms it should converge */
>> + migrate_set_parameter_int(from, "downtime-limit", 600);
>
> Comment doesn't match parameter!
Ooops.
>
> With those fixed;
>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Thanks.
