On 12/21/19 4:42 AM, Alex Bennée wrote: >> +/* >> + * TODO: Convert callers to compute cpu_mmu_index_kernel once >> + * and use *_mmuidx_ra directly. >> + */ > > I guess this would only be if it was a significant performance impact? > They seem to be mainly called for (I assume) infrequently called > helpers.
Yes, they are infrequent. But if you expose all of the hidden cpu_mmu_index_kernel() invocations, one should immediately ask why we're not caching the result in a local variable. If for nothing else, readability. r~
