On Thu, Dec 19, 2019 at 01:02:39AM +0100, Philippe Mathieu-Daudé wrote: > On 12/19/19 12:24 AM, Cleber Rosa wrote: > > Some tests may benefit from using resources from a build directory. > > This introduces three variables that can help tests find resources in > > those directories. > > > > First, a BLD_DIR is assumed to exist, given that the primary form of > > running the acceptance tests is from a build directory (which may or > > may not be the same as the source tree, that is, the SRC_DIR). > > Can we name this BUILD_DIR? >
Yes, of course. > This would be more in line with the other buildsys files (configure/make). > That's a good point. > > If the directory containing the acceptance tests happens to be a link > > to a directory (kept as LNK_DIR), it's assumed to it points to the > > source tree (SRC_DIR), which is the behavior defined on the QEMU > > Makefiles. If the directory containing the acceptance tests is not a > > link, then a in-tree build is assumed, and the BLD_DIR and SRC_DIR are > > the same and LNK_DIR is set None. > > Similarly, can we name this CURRENT_DIR instead of LNK_DIR? > Yes, or maybe even drop it? TBH, I can only see use cases for build and source dirs. So, I assume you'd propose SRC_DIR would be SOURCE_DIR? Cheers, - Cleber.
signature.asc
Description: PGP signature
