Corey Minyard <cminy...@mvista.com> writes: > On Sat, Nov 30, 2019 at 08:42:30PM +0100, Markus Armbruster wrote: >> isa_ipmi_bt_realize(), ipmi_isa_realize(), pci_ipmi_bt_realize(), and >> pci_ipmi_kcs_realize() crash when IPMIInterfaceClass method init() >> fails and their @errp argument is null. First messed up in commit >> 0719029c47 "ipmi: Add an ISA KCS low-level interface", then imitated >> in commit a9b74079cb "ipmi: Add a BT low-level interface" and commit >> 12f983c6aa "ipmi: Add PCI IPMI interfaces". >> >> The bug can't bite as no caller actually passes null, and none of the >> init() methods can actually fail. Fix it anyway. > > Well, whatever. It looks correct and is better style. I've added this > to my tree.
I've since posted v2 with a revamped commit message, and I'm ready to post a pull request. I really want the whole thing committed before the Christmas break, so Vladimir can base on it more easily. Options: * You post a pull request before me. * Ask me to drop this patch from my pull request, so you can take it through your tree at your leisure. * Post your Reviewed-by or Acked-by for me to include in my pull request. * Do nothing; I'll post my pull request later this week.
