Re: [PATCH 06/10] dp8393x: Clear RRRA command register bit only when appropriate

[Philippe Mathieu-Daudé]

On 12/14/19 2:25 AM, Finn Thain wrote:

It doesn't make sense to clear the command register bit unless the
command was actually issued.

Signed-off-by: Finn Thain <fth...@telegraphics.com.au>

Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>

---
  hw/net/dp8393x.c | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index 494deb42bf..3fdc6cc6f9 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -337,9 +337,6 @@ static void dp8393x_do_read_rra(dp8393xState *s)
          s->regs[SONIC_ISR] |= SONIC_ISR_RBE;
          dp8393x_update_irq(s);
      }
-
-    /* Done */
-    s->regs[SONIC_CR] &= ~SONIC_CR_RRRA;
  }

static void dp8393x_do_software_reset(dp8393xState *s)

@@ -548,8 +545,10 @@ static void dp8393x_do_command(dp8393xState *s, uint16_t 
command)
          dp8393x_do_start_timer(s);
      if (command & SONIC_CR_RST)
          dp8393x_do_software_reset(s);
-    if (command & SONIC_CR_RRRA)
+    if (command & SONIC_CR_RRRA) {
          dp8393x_do_read_rra(s);
+        s->regs[SONIC_CR] &= ~SONIC_CR_RRRA;
+    }
      if (command & SONIC_CR_LCAM)
          dp8393x_do_load_cam(s);
  }