On Tue, Dec 10, 2019 at 12:32 AM Eduardo Habkost <ehabk...@redhat.com> wrote:
>
> On Tue, Dec 03, 2019 at 09:07:15PM +0200, Yuri Benditovich wrote:
> > If the redirected device has this capability, Windows guest may
> > place the device into D2 and expect it to wake when the device
> > becomes active, but this will never happen. For example, when
> > internal Bluetooth adapter is redirected, keyboards and mice
> > connected to it do not work. Current commit removes this
> > capability (starting from machine 4.2)
> > Set 'usb-host.suppress-remote-wake' property to 'off' to keep
> > 'remote wake' as is or to 'on' to remove 'remote wake' on
> > 4.1 or earlier.
> >
> > Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com>
> > ---
> > hw/core/machine.c | 1 +
> > hw/usb/host-libusb.c | 20 ++++++++++++++++++++
> > hw/usb/trace-events | 1 +
> > 3 files changed, 22 insertions(+)
> >
> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index 1689ad3bf8..8c0eaad091 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -29,6 +29,7 @@
> >
> > GlobalProperty hw_compat_4_1[] = {
> > { "virtio-pci", "x-pcie-flr-init", "off" },
> > + { "usb-host", "suppress-remote-wake", "off" },
> > };
> > const size_t hw_compat_4_1_len = G_N_ELEMENTS(hw_compat_4_1);
>
> In case this doesn't get merged in QEMU 4.2.0, the patch needs to
> be updated to change hw_compat_4_2 instead (after applying the
> 5.0 machine type patch[1]).
Of course I will resubmit if needed.
>
> [1] https://patchew.org/QEMU/20191112104811.30323-1-coh...@redhat.com/
>
> --
> Eduardo
>
