On Fri, 6 Dec 2019 at 18:00, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 12/6/19 7:45 AM, Peter Maydell wrote: > > On Tue, 3 Dec 2019 at 02:29, Richard Henderson > > <richard.hender...@linaro.org> wrote: > >> > >> This is part of a reorganization to the set of mmu_idx. > >> This emphasizes that they apply to the EL1&0 regime. > > > > It loses the important point that they are stage 1&2 > > translations rather than stage 1 or stage 2, though, > > and also now they're out of line with the naming convention > > that all the other indexes use :-( > > It won't be out of line once all of the other renamings are done.
I think it might be easier to review if I could see the intended final set of names in one place (eg in the commit message to this patch), rather than getting them a bit at a time (though that is definitely the right way to structure the code changes themselves). thanks -- PMM