On 06/02/2011 08:12 AM, David Gibson wrote: > --- a/hw/pci_internals.h > +++ b/hw/pci_internals.h > @@ -14,8 +14,15 @@ > > extern struct BusInfo pci_bus_info; > > +typedef DMAMmu *(*pci_iommu_new_device_fn)(PCIBus *); > + > +struct PCIBusIOMMU { > + pci_iommu_new_device_fn new_device; > +}; > + > struct PCIBus { > BusState qbus; > + PCIBusIOMMU *iommu;
Is there a reason that you put PCIBusIOMMU here and not in pci.h? At present, the only users of pci_internals.h are the core pci implementation files, not pci host bridges, not pci devices. Modulo that, I can live with this arrangement. r~