Thomas Huth <th...@redhat.com> writes:
> On 28/11/2019 22.06, Stefan Weil wrote:
>> Am 28.11.19 um 16:35 schrieb Thomas Huth:
>>
>>> So far we only have compile coverage for tci. But since commit
>>> 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation
>>> for INDEX_op_ld16u_i64") has been included now, we can also run the
>>> "tcg" and "qtest" tests with tci, so let's enable them in Travis now.
>>> Since we don't gain much additional test coverage by compiling all
>>> targets, and TCI is broken e.g. with the Sparc targets, we also limit
>>
>>
>> As far as I know it is broken with Sparc hosts (not Sparc targets).
>
> It was definitely hanging with sparc64-softmmu:
>
> https://travis-ci.com/huth/qemu/jobs/261335163
>
> ... but since you've mentioned that it should work with the 32-bit
> sparc-softmmu, I'll give it another try with sparc-softmmu.
>
>>> the target list to a reasonable subset now (which should still get
>>> us test coverage by tests/boot-serial-test for example).
>>>
>>> Signed-off-by: Thomas Huth <th...@redhat.com>
>>> ---
>>> .travis.yml | 7 ++++---
>>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index c09b6a0014..de7559e777 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -215,10 +215,11 @@ matrix:
>>> - TEST_CMD=""
>>>
>>>
>>> - # We manually include builds which we disable "make check" for
>>> + # Check the TCG interpreter (TCI)
>>> - env:
>>> - - CONFIG="--enable-debug --enable-tcg-interpreter"
>>> - - TEST_CMD=""
>>> + - CONFIG="--enable-debug --enable-tcg-interpreter
>>> --disable-containers
>>
>>
>> You could also --disable-kvm. It should not be needed, and disabling it
>> might need less build resources.
>
> Good idea. KVM is not usable by default in Travis, so we should not
> accidentally use it for the tests that specify "accel=kvm:tcg", but in
> case that changes with a future version of the environment, we should
> maybe be prepared.
Makes sense, I'll wait for v3 before applying to me tree.
>
>>> +
>>> --target-list=alpha-softmmu,arm-softmmu,hppa-softmmu,m68k-softmmu,microblaze-softmmu,moxie-softmmu,ppc-softmmu,s390x-softmmu,x86_64-softmmu"
>>> + - TEST_CMD="make check-qtest check-tcg V=1"
>>>
>>>
>>> # We don't need to exercise every backend with every front-end
>>
>>
>> Thank you for adding these tests.
>>
>> Tested-by: Stefan Weil <s...@weilnetz.de>
>
> Thanks,
> Thomas
--
Alex Bennée
