On Mon, 2 Dec 2019 at 16:08, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> On 12/1/19 6:08 AM, David Gibson wrote:
> >
> > - for (i = 0; i < s->num_cpu; i++) {
> > + /*
> > + * This clues in gcc that our on-stack buffers do, in fact have
> > + * enough room for the cpu numbers. gcc 9.2.1 on 32-bit x86
> > + * doesn't figure this out, otherwise and gives spurious warnings.
> > + */
> > + assert(n <= EXYNOS4210_NCPUS);
> > + for (i = 0; i < n; i++) {
> > +
> > /* Map CPU interface per SMP Core */
>
> Watch out for the extra line added at the start of the block. Otherwise,
>
> Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
I thought about putting this in rc4 but eventually decided
against it. Queued for 5.0 (with the stray extra blank line removed).
thanks
-- PMM
