On 27/11/2019 18.50, Janosch Frank wrote:
Let's start moving the cpu reset functions into a single function with a switch/case, so we can use fallthroughs and share more code between resets.
Nit: I'd add a "later" in above sentence, since you don't use fallthroughs yet.
This patch introduces the reset function by renaming cpu_reset() and cleaning up leftovers.
Hmm, which leftovers? I can mainly see the renaming here...
Signed-off-by: Janosch Frank <fran...@linux.ibm.com> Reviewed-by: David Hildenbrand <da...@redhat.com> --- target/s390x/cpu-qom.h | 6 +++++- target/s390x/cpu.c | 19 +++++++++++++------ target/s390x/cpu.h | 2 +- target/s390x/sigp.c | 2 +- 4 files changed, 20 insertions(+), 9 deletions(-)
Anyway, Reviewed-by: Thomas Huth <th...@redhat.com>