Re: [PATCH 2/4] s390x: Cleanup cpu resets

[David Hildenbrand]

[...]

#if !defined(CONFIG_USER_ONLY)

@@ -473,9 +459,9 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)
  #if !defined(CONFIG_USER_ONLY)
      scc->load_normal = s390_cpu_load_normal;
  #endif
-    scc->cpu_reset = s390_cpu_reset;
-    scc->initial_cpu_reset = s390_cpu_initial_reset;
-    cc->reset = s390_cpu_full_reset;
+    scc->cpu_reset = s390_cpu_reset_normal;
+    scc->initial_cpu_reset = s390_cpu_reset_initial;

What about having only one function here

scc->cpu_reset(), where you directly pass in the reset type

instead of scc->cpu_reset/scc->initial_cpu_reset?

+    cc->reset = s390_cpu_reset_clear;
      cc->class_by_name = s390_cpu_class_by_name,
      cc->has_work = s390_cpu_has_work;
  #ifdef CONFIG_TCG

--

Thanks,

David / dhildenb