On Fri, Nov 15, 2019 at 03:55:40PM -0500, Vivek Goyal wrote: > diff --git a/contrib/virtiofsd/passthrough_ll.c > b/contrib/virtiofsd/passthrough_ll.c > index bc214df0c7..028e7da273 100644 > --- a/contrib/virtiofsd/passthrough_ll.c > +++ b/contrib/virtiofsd/passthrough_ll.c > @@ -936,6 +936,14 @@ static void put_shared(struct lo_data *lo, struct > lo_inode *inode) > } > } > > +static void release_plock(gpointer data)
The name posix_locks_value_destroy() would be clearer because it matches g_hash_table_new_full() terminology and the function cannot be confused with a lock acquire/release operation. This patch conflicts with the cleanups that are currently being made to virtiofsd: https://github.com/stefanha/qemu/commit/1e493175feca58a81a2d0cbdac93b92e5425d850#diff-ca2dea995d1e6cdb95c8a47c7cca51ceR773 Stefan
signature.asc
Description: PGP signature
