On 11/18/19 5:58 PM, Taylor Simpson wrote:
In addition to what others have said, you have an atypical and long
subject line. You'll want to rewrite it to match more typical subject
lines (around 65 characters) then a blank line then the additional
details. 'git shortlog -30' might give you some ideas on how to do it;
you'll probably want to use 'hexagon:' as your prefix.
Signed-off-by: Taylor Simpson <tsimp...@quicinc.com>
---
31 files changed, 2184 insertions(+)
That's a big patch. How much of it is copied verbatim from elsewhere
and how much is new code? Splitting the patch along those lines makes
review of the non-copied portion easier.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org