On 19/11/2019 13.13, Paolo Bonzini wrote:
> On 19/11/19 12:56, Thomas Huth wrote:
>>> - if (machine_kernel_irqchip_split(machine)) {
>>> + if (kvm_enabled() && kvm_kernel_irqchip_split()) {
>>> error_setg(errp, "kernel_irqchip split mode not supported on
>>> pseries");
>>> return;
>>> }
>> Any reason for the additional kvm_enabled() here? I think it should also
>> be ok without that?
>>
>> Apart from that question, patch looks fine to me.
>
> It won't compile without that, kvm_kernel_irqchip_split() is defined in
> accel/kvm/kvm-all.c.
Oh, I wonder whether you need a stub for certain compilers? ... but if
all our supported compilers are fine with this, I'm fine with it, too.
Reviewed-by: Thomas Huth <th...@redhat.com>
