On Thu, 14 Nov 2019 at 09:36, Paolo Bonzini <pbonz...@redhat.com> wrote: > > On 14/11/19 10:10, Thomas Huth wrote: > >> "info mtree" prints the wrong accelerator name if used with for example > >> "-machine accel=kvm:tcg". > > I had a quick look at the output of "info mtree" with and without > > "accel=kvm:tcg", but I could not spot any obvious places where it's > > wrong. Could you give an example? > > Indeed the commit message should say "info mtree -f". > > $ x86_64-softmmu/qemu-system-x86_64 -M microvm -enable-kvm -machine > accel=kvm:tcg -monitor stdio > QEMU 4.1.50 monitor - type 'help' for more information > (qemu) info mtree -f > ... > FlatView #1 > AS "memory", root: system > AS "cpu-memory-0", root: system > Root memory region: system > 0000000000000000-00000000000effff (prio 0, ram): microvm.ram kvm:tcg > 00000000000f0000-00000000000fffff (prio 0, ram): pc.bios kvm:tcg > 0000000000100000-0000000007ffffff (prio 0, ram): microvm.ram > @0000000000100000 kvm:tcg
Why do we need to print the accelerator name for every memory region? Isn't it just a global property, or at least a property of the CPU ? thanks -- PMM
