On Wed, Nov 13, 2019 at 10:38:06AM -0500, Jag Raman wrote: > > > On 11/13/2019 10:30 AM, Stefan Hajnoczi wrote: > > On Thu, Oct 24, 2019 at 05:08:43AM -0400, Jagannathan Raman wrote: > > > qemu_thread_cancel() added to destroy a given running thread. > > > This will be needed in the following patches. > > > > > > Signed-off-by: John G Johnson <john.g.john...@oracle.com> > > > Signed-off-by: Jagannathan Raman <jag.ra...@oracle.com> > > > Signed-off-by: Elena Ufimtseva <elena.ufimts...@oracle.com> > > > --- > > > include/qemu/thread.h | 1 + > > > util/qemu-thread-posix.c | 10 ++++++++++ > > > 2 files changed, 11 insertions(+) > > > > Is this still needed? I thought previous discussion concluded that > > thread cancellation is hard to get right and it's not actually used by > > this series? > > Hi Stefan, > > This is used in PATCH 41/49.
I don't believe the cancellation usage in that patch is safe :-) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
