Am 28.05.2011 um 16:03 schrieb Alexander Graf:

On 28.05.2011, at 16:01, Andreas Färber wrote:

diff --git a/libfdt_env.h b/libfdt_env.h
index ee0419f..90d7f3b 100644
--- a/libfdt_env.h
+++ b/libfdt_env.h
@@ -19,13 +19,9 @@
#ifndef _LIBFDT_ENV_H
#define _LIBFDT_ENV_H

-#include <stddef.h>
-#include <stdint.h>
-#include <string.h>
-#include <endian.h>
-#include <byteswap.h>
+#include "bswap.h"

-#if __BYTE_ORDER == __BIG_ENDIAN
+#ifdef HOST_WORDS_BIGENDIAN

Hrm. Who defines HOST_WORDS_BIGENDIAN? Shouldn't you explicitly include that header file?

bswap.h includes config-host.h, why duplicate that. Let's not make Stefan more work. :)

Or at least have a sanity check that breaks compilation if neither BIG nor LITTLE endian are defined? :)

We don't have generic defines for BIG or LITTLE endian, cf. original warning message. That's why I'm checking what we do have - configure knows best.

Andreas

Reply via email to