On Mon, Oct 28, 2019 at 08:58:01AM +0100, Aleksandar Markovic wrote: > On Monday, October 28, 2019, Philippe Mathieu-Daudé <phi...@redhat.com> > wrote: > > > From: Cleber Rosa <cr...@redhat.com> > > > > The same utility method is already present in two different test > > files, so let's consolidate it into a single utility function. > > > > Signed-off-by: Cleber Rosa <cr...@redhat.com> > > Message-Id: <20190916164011.7653-1-cr...@redhat.com> > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > [PMD: failure_message is optional] > > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > --- > > tests/acceptance/avocado_qemu/__init__.py | 25 +++++++++++++++++++++ > > tests/acceptance/boot_linux_console.py | 27 +++++------------------ > > tests/acceptance/linux_ssh_mips_malta.py | 18 +++------------ > > 3 files changed, 33 insertions(+), 37 deletions(-) > > > > > > You missed my r-b, that I gave here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg06378.html > > A. >
Hi Aleksandar, I've collected your review, it'll be on my PR. Thanks! - Cleber.