On 26 May 2011 20:01, Blue Swirl <blauwir...@gmail.com> wrote: > On Wed, May 25, 2011 at 7:00 PM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> This obviously still leaves some global CPUState use in op_helper.c, >> but it's a move in the right direction. > > Have you seen any measurable changes in performance? The discussion > about the performance effect of changes like this was not very > conclusive.
Nope, I haven't measured. I was persuaded of the advantages of dropping global CPUState purely for (a) consistency and (b) avoiding nasty hacks. -- PMM