On 10/23/19 1:09 PM, Zhang, Chen wrote:
-----Original Message-----
From: Philippe Mathieu-Daudé <phi...@redhat.com>
Sent: Wednesday, October 23, 2019 7:01 PM
To: Zhang, Chen <chen.zh...@intel.com>; Jason Wang
<jasow...@redhat.com>; Paolo Bonzini <pbonz...@redhat.com>; qemu-
dev <qemu-devel@nongnu.org>
Cc: Zhang Chen <zhangc...@gmail.com>
Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog
module framework
Hi Chen,
On 10/16/19 1:22 PM, Zhang Chen wrote:
From: Zhang Chen <chen.zh...@intel.com>
This patch introduce a new module named Advanced Watch Dog, and
defined the input and output parameter. AWD use standard chardev as
the way of communicationg with the outside world.
Demo command:
-object
advanced-
watchdog,id=heart1,server=on,awd_node=h1,notification_node=he
artbeat0,opt_script=opt_script_path,iothread=iothread1,pulse_interval=
1000,timeout=5000
Signed-off-by: Zhang Chen <chen.zh...@intel.com>
---
net/Makefile.objs | 1 +
net/awd.c | 261
++++++++++++++++++++++++++++++++++++++++++++++
qemu-options.hx | 6 ++
3 files changed, 268 insertions(+)
create mode 100644 net/awd.c
diff --git a/net/Makefile.objs b/net/Makefile.objs index
c5d076d19c..139b1394e9 100644
--- a/net/Makefile.objs
+++ b/net/Makefile.objs
@@ -19,6 +19,7 @@ common-obj-y += colo-compare.o
common-obj-y += colo.o
common-obj-y += filter-rewriter.o
common-obj-y += filter-replay.o
+common-obj-y += awd.o
Can you add a net/Kconfig file introducing the ADVANCED_WATCHDOG
selector?
config COLO_ADVANCED_WATCHDOG
bool
default n
Then use here:
common-obj-$(COLO_ADVANCED_WATCHDOG) += awd.o
Sure, but AWD is a universal module, COLO is just the first user.
Maybe use "config ADVANCED_WATCHDOG" is better.
Oh I see, better then.
Then we might add (later)
config COLO
...
select ADVANCED_WATCHDOG
Thanks!
Phil.
tap-obj-$(CONFIG_LINUX) = tap-linux.o
tap-obj-$(CONFIG_BSD) = tap-bsd.o
[...]
