On Tue, 22 Oct 2019 at 17:24, Marc-André Lureau <marcandre.lur...@redhat.com> wrote: > > Instead, set the initial data field directly. > > (the initial data is an array of 256 bytes. As I don't know if it may > change over time, I keep the pointer to original buffer as is, but it > might be worth to consider to copy it instead)
All the callers to smbus_eeprom_init_one() allocate the memory for the initial data, populate it, pass the pointer to smbus_eeprom_init_one() and do not save the pointer anyway. So we effectively "own" the data -- we could choose to copy the data and make the callers free the memory instead. > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> I'd still like to know what the right QOM way to pass 256 bytes of constant data to a device as a property is. thanks -- PMM
