On Wed, 16 Oct 2019 at 09:54, Andrew Jones <drjo...@redhat.com> wrote: > > Since Linux kernel v5.2-rc1 KVM has support for enabling SVE in guests. > This series provides the QEMU bits for that enablement. First, we > select existing CPU properties representing features we want to > advertise in addition to the SVE vector lengths and prepare > them for a qmp query. Then we introduce the qmp query, applying > it immediately to those selected features. We also document ARM CPU > features at this time. We next add a qtest for the selected CPU > features that uses the qmp query for its tests - and we continue to > add tests as we add CPU features with the following patches. So then, > once we have the support we need for CPU feature querying and testing, > we add our first SVE CPU feature property, 'sve', which just allows > SVE to be completely enabled/disabled. Following that feature property, > we add all 16 vector length properties along with the input validation > they need and tests to prove the validation works. At this point the > SVE features are still only for TCG, so we provide some patches to > prepare for KVM and then a patch that allows the 'max' CPU type to > enable SVE with KVM, but at first without vector length properties. > After a bit more preparation we add the SVE vector length properties > to the KVM-enabled 'max' CPU type along with the additional input > validation and tests that that needs. Finally we allow the 'host' > CPU type to also enjoy these properties by simply sharing them with it.
This fails 'make check' on an aarch32 box with KVM support: MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} QTEST_QEMU_BINARY=arm-softmmu/qemu-system-arm QTEST_QEMU_IMG=qemu-img tests/arm-cpu-features -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="arm-cpu-features" PASS 1 arm-cpu-features /arm/arm/query-cpu-model-expansion ** ERROR:/home/pm215/qemu/tests/arm-cpu-features.c:420:test_query_cpu_model_expansion_kvm: assertion failed: (resp_has_props(_resp)) Aborted ERROR - too few tests run (expected 2, got 1) /home/pm215/qemu/tests/Makefile.include:902: recipe for target 'check-qtest-arm' failed make: *** [check-qtest-arm] Error 1 make: Leaving directory '/home/pm215/qemu/build/arm' thanks -- PMM