On 18/10/2019 11:42, Cédric Le Goater wrote: > On 18/10/2019 05:55, David Gibson wrote: >> On Thu, Oct 17, 2019 at 04:42:41PM +0200, Cédric Le Goater wrote: >>> When a Virtual Processor is scheduled to run on a HW thread, the >>> hypervisor pushes its identifier in the OS CAM line. When running in >>> TCG or kernel_irqchip=off, QEMU needs to emulate the same behavior. >>> >>> Introduce a 'os-cam' property which will be used to set the OS CAM >>> line at reset and remove the spapr_xive_set_tctx_os_cam() calls which >>> are done when the XIVE interrupt controller are activated. >> >> I'm not immediately seeing the advantage of doing this via a property, >> rather than poking it from the PAPR code which already knows the right >> values. > > we can simplify by passing the OS CAM line value as a parameter of the > xive_tctx_reset routine, as suggested by Greg.
and if we remove the reset handlers from XiveTCTX and rely only on the CPU reset handler to reset the presenter. C.
