This patchset converts the devices used by the miscellaneous minor architecture machines to the new ptimer API. More specifically:
cris: hw/timer/etraxfs_timer.c lm32: hw/timer/lm32_timer.c hw/timer/milkymist-sysctl.c nios2: hw/timer/altera_timer.c sh4: hw/timer/sh_timer.c unicore32: hw/timer/puv3_ost.c m68k: hw/m68k/mcf5206.c hw/m68k/mcf5208.c Currently the ptimer design uses a QEMU bottom-half as its mechanism for calling back into the device model using the ptimer when the timer has expired. Unfortunately this design is fatally flawed, because it means that there is a lag between the ptimer updating its own state and the device callback function updating device state, and guest accesses to device registers between the two can return inconsistent device state. This was reported as a bug in a specific timer device but it's a problem with the generic ptimer code: https://bugs.launchpad.net/qemu/+bug/1777777 The updates to the individual ptimer devices are straightforward: we need to add begin/commit calls around the various places that modify the ptimer state, and use the new ptimer_init() function to create the timer. Testing I have done: * 'make check' * running a milkymist system image I had lying around * running an sh4 system image This doesn't exercise the devices very much, so more specific testing would be appreciated. I plan to collect these patches up and get them into the tree with other ptimer-related changes (probably via target-arm just for convenience) unless anybody would specifically like to take a patch via some other tree. thanks --PMM Peter Maydell (8): hw/timer/puv3_ost.c: Switch to transaction-based ptimer API hw/timer/sh_timer: Switch to transaction-based ptimer API hw/timer/lm32_timer: Switch to transaction-based ptimer API hw/watchdog/milkymist-sysctl.c: Switch to transaction-based ptimer API hw/timer/altera_timer.c: Switch to transaction-based ptimer API hw/watchdog/etraxfs_timer.c: Switch to transaction-based ptimer API hw/m68k/mcf5206.c: Switch to transaction-based ptimer API hw/m68k/mcf5208.c: Switch to transaction-based ptimer API hw/m68k/mcf5206.c | 9 +++++---- hw/m68k/mcf5208.c | 9 +++++---- hw/timer/altera_timer.c | 13 +++++++++---- hw/timer/etraxfs_timer.c | 23 +++++++++++++---------- hw/timer/lm32_timer.c | 13 +++++++++---- hw/timer/milkymist-sysctl.c | 25 ++++++++++++++++++------- hw/timer/puv3_ost.c | 9 +++++---- hw/timer/sh_timer.c | 13 +++++++++---- 8 files changed, 73 insertions(+), 41 deletions(-) -- 2.20.1
