On Wed, Oct 16, 2019 at 03:25:53AM -0700, no-re...@patchew.org wrote: >Patchew URL: >https://patchew.org/QEMU/20191016012432.22731-1-richardw.y...@linux.intel.com/ > > > >Hi, > >This series seems to have some coding style problems. See output below for >more information: > >Subject: [PATCH] checkpatch: sugguest to use qemu_real_host_page_size instead >of getpagesize() or sysconf(_SC_PAGESIZE) >Type: series >Message-id: 20191016012432.22731-1-richardw.y...@linux.intel.com > >=== TEST SCRIPT BEGIN === >#!/bin/bash >git rev-parse base > /dev/null || exit 0 >git config --local diff.renamelimit 0 >git config --local diff.renames True >git config --local diff.algorithm histogram >./scripts/checkpatch.pl --mailback base.. >=== TEST SCRIPT END === > >Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 >Switched to a new branch 'test' >6c3e035 checkpatch: sugguest to use qemu_real_host_page_size instead of >getpagesize() or sysconf(_SC_PAGESIZE) > >=== OUTPUT BEGIN === >ERROR: line over 90 characters >#20: FILE: scripts/checkpatch.pl:2919: >+ ERROR("use qemu_real_host_page_size instead of >getpagesize()\n" . $herecurr); >
Since this is an error message and I see other similar code keep it in the same line, I didn't split it into two lines. If necessary, I would split it. -- Wei Yang Help you, Help me
