On 10/15/19 9:05 AM, Kevin Wolf wrote:
+@item force-share
+Override the image locking system of QEMU and force the node to allowing
+sharing all permissions with other uses.
Grammar nit: "to allow sharing"; but maybe the phrasing could
be clarified anyway -- I'm not entirely sure what 'sharing
permissions" would be. The first part of the sentence suggests
this option is "force the image file to be opened even if some
other QEMU instance has it open already", but the second half
soudns like "don't lock the image, so that some other use later
is allowed to open it" ? Or is it both, or something else?
It's more the latter. Open the image file and allow other instances to
have it open as well (existing and future instances), but still error
out if the other instance doesn't allow sharing.
I'm open for suggestions on how to phrase this better.
Here's a shot (although I'm not 100% certain I've captured the nuances
correctly):
Override the image locking system of QEMU by forcing the node to utilize
weaker shared access for permissions where it would normally request
exclusive access. When there is the potential for multiple instances to
have the same file open (whether this invocation of qemu is the first or
the second instance), both instances must permit shared access for the
second instance to succeed at opening the file.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
