On Mon, 14 Oct 2019 at 14:41, Hikaru Nishida <hikaru...@gmail.com> wrote: > > Thank you for your reply. > > The event gets fired before applicationDidFinishLaunching is: (output > of NSLog(@"event: %@", event);) > event: NSEvent: type=Kitdefined loc=(0,1440) time=164310.0 flags=0x40 > win=0x0 winNum=0 ctxt=0x0 subtype=1 data1=834 data2=0 > > I moved allow_events = true just before > qemu_sem_post(&app_started_sem) and it also works.
OK, great. I think we should go with that, then. I think a brief comment explaining the purpose of the flag would also be useful in the handleEvent function; something like this: /* * Just let OSX have all events that arrive before applicationDidFinishLaunching. * This avoids a deadlock on the iothread lock, which cocoa_display_init() * will not drop until after the app_started_sem is posted. (In theory * there should not be any such events, but OSX Catalina now emits some.) */ Could you send a v2 of the patch with 'allow_events = true' in the applicationDidFinishLaunching function, and that comment in handleEvent please, and we'll get that into the tree? thanks -- PMM
