On Monday, October 14, 2019, Markus Armbruster <arm...@redhat.com> wrote:
> Aleksandar Markovic <aleksandar.marko...@rt-rk.com> writes:
>
> > From: Aleksandar Markovic <amarko...@wavecomp.com>
> >
> > Mostly fix errors and warnings reported by 'checkpatch.pl -f'.
> >
> > Signed-off-by: Aleksandar Markovic <amarko...@wavecomp.com>
> > ---
> > target/mips/helper.c | 128 ++++++++++++++++++++++++++++++
> +--------------------
> > 1 file changed, 78 insertions(+), 50 deletions(-)
> >
> > diff --git a/target/mips/helper.c b/target/mips/helper.c
> > index a2b6459..2411a2c 100644
> > --- a/target/mips/helper.c
> > +++ b/target/mips/helper.c
> [...]
> > @@ -130,8 +133,11 @@ static int is_seg_am_mapped(unsigned int am, bool
> eu, int mmu_idx)
> > int32_t adetlb_mask;
> >
> > switch (mmu_idx) {
> > - case 3 /* ERL */:
> > - /* If EU is set, always unmapped */
> > + case 3:
> > + /*
> > + * ERL
> > + * If EU is set, always unmapped
> > + */
> > if (eu) {
> > return 0;
> > }
>
> Did you miss my review comment?
I just thought you soon realized that that your comment misinterpreted the
content of the patch. Anyway, I responded to your comment to v4.
Aleksandar
>
> Message-ID: <874l0ydk00....@dusky.pond.sub.org>
> https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg06719.html
>
> [...]
>
>
