On Wed, Oct 09, 2019 at 03:21:46PM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 07, 2019 at 03:44:40PM +0200, Sergio Lopez wrote: > > > > Michael S. Tsirkin <m...@redhat.com> writes: > > > > > On Fri, Oct 04, 2019 at 11:37:42AM +0200, Sergio Lopez wrote: > > >> Microvm is a machine type inspired by Firecracker and constructed > > >> after the its machine model. > > >> > > >> It's a minimalist machine type without PCI nor ACPI support, designed > > >> for short-lived guests. Microvm also establishes a baseline for > > >> benchmarking and optimizing both QEMU and guest operating systems, > > >> since it is optimized for both boot time and footprint. > > > > > > Pls take a look at patchew warnings and errors. > > > Both coding style issues and test failures need to be > > > addressed somehow I think. > > > > I've fixed the issue with the test suite, but I'm not sure what to do > > about the coding style errors. Every one of them (except perhaps one at > > xen-hvm.c) comes from code I've moved from pc.c to x86.c. I'd say fixing > > those are outside the scope of the corresponding patches, but please > > correct me if I'm wrong. > > Yea if you refactor code you have to kick it into shape > at the same time. Can be a separate patch to ease review.
I don't think it is reasonable to require code to be 100% CODING_STYLE-compliant before being moved to a new file. We can still encourage cleaning it up, of course, but I don't see the benefit of making it a requirement. -- Eduardo
