On 2011-05-23 10:43, Markus Armbruster wrote: > Jan Kiszka <jan.kis...@siemens.com> writes: > >> Drop the open-coded MAC assignment from net_init_nic and replace it with >> standard qemu_macaddr_default_if_unset which is also used by qdev. That >> avoid creating colliding MACs when instantiating NICs via different >> mechanisms. > > Should we explicitly mention that this may change default MAC addresses?
Only if mixing old (-net) and new (-device) mechanisms. > >> This change requires to store the MAC as MACAddr in NICInfo, and the >> remaining nd_table users need to be updated. >> >> Based on suggestion by Peter Maydell. > > Patch looks fine to me. Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
