On Fri, 4 Oct 2019 at 09:02, David Hildenbrand <da...@redhat.com> wrote: > So shall we leave this patch as-is (adding a summary of what you > explained to the description) or shall we somehow factor out the > TCG-internal-thingy check?
Nothing else in target code touches the icount data structures, so if this s390 insn needs to make this check I think it ought to do it by calling a function implemented by the tcg code; that can then have a good name that describes what it's doing and a doc comment explaining the reason we need to have it. thanks -- PMM
