On Wed, 2 Oct 2019 at 17:18, Kevin Wolf <kw...@redhat.com> wrote:
>
> The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc:
>
> Merge remote-tracking branch
> 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01
> 13:13:38 +0100)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 352492e5541e293ea8117412ffd171ce1c7ac15d:
>
> iotests: Remove Python 2 compatibility code (2019-10-02 16:47:23 +0200)
>
> ----------------------------------------------------------------
> Block layer patches:
>
> - Fix internal snapshots with typical -blockdev setups
> - iotests: Require Python 3.6 or later
>
> ----------------------------------------------------------------
> Kevin Wolf (4):
> block/snapshot: Restrict set of snapshot nodes
> iotests: Test internal snapshots with -blockdev
> iotests: Require Python 3.6 or later
> iotests: Remove Python 2 compatibility code
Hi. This failed on iotest 267 on the ppc build machine I test on,
in the same way that the patchew report for centos7 failed:
--- /home/pm215/qemu/tests/qemu-iotests/267.out 2019-10-03
15:35:50.099974113 +0000
+++ /home/pm215/qemu/build/all/tests/qemu-iotests/267.out.bad
2019-10-03 15:41:46.190579461 +0000
@@ -3,180 +3,770 @@
=== No block devices at all ===
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
-Testing:
-QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) savevm snap0
-Error: No block device can accept snapshots
-(qemu) info snapshots
-No available block device supports snapshots
-(qemu) loadvm snap0
-Error: No block device supports snapshots
-(qemu) quit
+Usage: sed [OPTION]... {script-only-if-no-other-script} [input-file]...
+ -n, --quiet, --silent
+ suppress automatic printing of pattern space
+ -e script, --expression=script
+ add the script to the commands to be executed
[etc]
The machine is running 'sed (GNU sed) 4.2.2'.
It looks like this version of sed doesn't like it if you
specify '-r' twice, as you have done in the _filter_vmstate_size()
function in common.filter in the "iotests: Test internal snapshots
with -blockdev" patch. I think '-r' is supposed to apply to all
scripts in the sed invocation; if that's correct then a command
line like '-re thing1 -re thing2' is confusing and would be better
written '-r -e thing1 -e thing2' even if this older sed didn't
complain about it.
thanks
-- PMM
