On 02/10/2019 19.32, Alex Bennée wrote: > > Daniel P. Berrangé <berra...@redhat.com> writes: > >> On Wed, Oct 02, 2019 at 04:21:46PM +0200, Thomas Huth wrote: >>> Running the iotests during "make check" is causing more headaches than >>> benefits for the block layer maintainers, so let's disable the iotests >>> during "make check" again. >>> >>> Signed-off-by: Thomas Huth <th...@redhat.com> >>> --- >>> tests/Makefile.include | 2 +- >>> tests/qemu-iotests/group | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> I don't have any objection to removing from 'make check', but I feel >> like this commit should be modifying the travis.yml config so that >> it explicitly runs the block tests, otherwise we're loosing automated >> CI and the block tests will increase their rate of bitrot again. > > I think we run a subset on gitlab as well. Do the iotests need any > particular build of QEMU? Lets try and avoid adding unneeded targets.
The tests that are currently specified in .gitlab-ci.yml explicitly are only tests that are not part of the "auto" group, i.e. not part of "make check-block". So if we just run "make check-block" in Travis, we do not have any overlap. > I must admit I've been out of the loop here. What headaches are they > causing? Too many false positives? See this thread here: https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00288.html Thomas
