Patchew URL: https://patchew.org/QEMU/20191001235552.17790-1-js...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20191001235552.17790-1-js...@redhat.com
Subject: [PULL 0/8] Ide patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
1f9b401 hd-geo-test: Add tests for lchs override
7bfdda4 bootdevice: FW_CFG interface for LCHS values
b6feb64 bootdevice: Refactor get_boot_devices_list
ab60aa0 bootdevice: Gather LCHS from all relevant devices
e12a839 scsi: Propagate unrealize() callback to scsi-hd
e6f21f3 bootdevice: Add interface to gather LCHS
40120f4 block: Support providing LCHS from user
adcf56d block: Refactor macros - fix tabbing
=== OUTPUT BEGIN ===
1/8 Checking commit adcf56d080c9 (block: Refactor macros - fix tabbing)
ERROR: Macros with complex values should be enclosed in parenthesis
#57: FILE: include/hw/block/block.h:65:
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
+ DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
+ DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
total: 1 errors, 0 warnings, 37 lines checked
Patch 1/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/8 Checking commit 40120f44b44f (block: Support providing LCHS from user)
3/8 Checking commit e6f21f35debf (bootdevice: Add interface to gather LCHS)
4/8 Checking commit e12a839d2b12 (scsi: Propagate unrealize() callback to
scsi-hd)
5/8 Checking commit ab60aa0f51a5 (bootdevice: Gather LCHS from all relevant
devices)
6/8 Checking commit b6feb64ebaef (bootdevice: Refactor get_boot_devices_list)
7/8 Checking commit 7bfdda4eaaf4 (bootdevice: FW_CFG interface for LCHS values)
8/8 Checking commit 1f9b401195bc (hd-geo-test: Add tests for lchs override)
WARNING: Block comments use a leading /* on a separate line
#650: FILE: tests/hd-geo-test.c:1003:
+ "skipping hd-geo/override/* tests");
total: 0 errors, 1 warnings, 616 lines checked
Patch 8/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191001235552.17790-1-js...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
