On Wed, Sep 25, 2019 at 2:47 PM Aleksandar Markovic <aleksandar.marko...@rt-rk.com> wrote: > > From: Aleksandar Markovic <amarko...@wavecomp.com> > > Mostly cosmetic changes. > > Aleksandar Markovic (20): > target/mips: Clean up helper.c > target/mips: Clean up internal.h > target/mips: Clean up kvm_mips.h > target/mips: Clean up mips-defs.h > target/mips: Clean up op_helper.c > target/mips: Clean up translate.c > target/mips: msa: Split helpers for <NLOC|NLZC>.<B|H|W|D> > target/mips: msa: Split helpers for PCNT.<B|H|W|D> > target/mips: msa: Split helpers for BINS<L|R>.<B|H|W|D> > target/mips: msa: Unroll loops and demacro <BMNZ|BMZ|BSEL>.V > target/mips: msa: Split helpers for B<CLR|NEG|SEL>.<B|H|W|D> > target/mips: msa: Split helpers for AVE_<S|U>.<B|H|W|D> > target/mips: msa: Split helpers for AVER_<S|U>.<B|H|W|D> > target/mips: msa: Split helpers for CEQ.<B|H|W|D> > target/mips: msa: Split helpers for CLE_<S|U>.<B|H|W|D> > target/mips: msa: Split helpers for CLT_<S|U>.<B|H|W|D> > target/mips: msa: Split helpers for DIV_<S|U>.<B|H|W|D> > target/mips: msa: Split helpers for MOD_<S|U>.<B|H|W|D> > target/mips: msa: Simplify and move helper for MOVE.V > target/mips: msa: Move helpers for <AND|NOR|OR|XOR>.V > > target/mips/helper.c | 132 +-- > target/mips/helper.h | 144 +++- > target/mips/internal.h | 60 +- > target/mips/kvm_mips.h | 2 +- > target/mips/mips-defs.h | 53 +- > target/mips/msa_helper.c | 2115 > ++++++++++++++++++++++++++++++++++++---------- > target/mips/op_helper.c | 913 +++++++++++++------- > target/mips/translate.c | 421 +++++++-- > 8 files changed, 2888 insertions(+), 952 deletions(-) > > --
I applied patches 2-4 and 6-20 to MIPS queue, as there was no disagreement about them. I did some corrections as said by Philippe and Aleksandar R. There were more inaccuracies in MSA patches, which I corrected with the little help of unit tests. All MSA unit tests pass now. Patches 1 (helper.c) and 5 (op_helper.c) are left for future versions (so, not abandoned, will be improved). Aleksandar > 2.7.4 > >
