On 10/1/19 3:36 AM, Paolo Bonzini wrote:
> On 26/09/19 20:35, Alex Bennée wrote:
>> From: John Snow <js...@redhat.com>
>>
>> Fedora23 is but a distant twinkle. The sanitizer works again, and even
>> if not, we have --enable-sanitizers now.
>>
>> Signed-off-by: John Snow <js...@redhat.com>
>> Message-Id: <20190912014442.5757-1-js...@redhat.com>
>> Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
>>
>> diff --git a/tests/docker/test-clang b/tests/docker/test-clang
>> index 324e341cea..db9e6970b7 100755
>> --- a/tests/docker/test-clang
>> +++ b/tests/docker/test-clang
>> @@ -17,11 +17,7 @@ requires clang
>>
>> cd "$BUILD_DIR"
>>
>> -OPTS="--cxx=clang++ --cc=clang --host-cc=clang"
>> -# -fsanitize=undefined is broken on Fedora 23, skip it for now
>> -# See also: https://bugzilla.redhat.com/show_bug.cgi?id=1263834
>> -#OPTS="$OPTS --extra-cflags=-fsanitize=undefined \
>> - #--extra-cflags=-fno-sanitize=float-divide-by-zero"
>> +OPTS="--cxx=clang++ --cc=clang --host-cc=clang --enable-sanitizers"
>> build_qemu $OPTS
>> check_qemu
>> install_qemu
>>
>
> -fsanitize=undefined is not the same thing as --enable-sanitizers. This
> is basically duplicating the asan (test-debug) test now.
>
> In fact, since we have the asan test that includes all sanitizers
> including ubsan, I think it's easiest to just revert this patch.
>
Ah, whoops :(
Sorry about that, just go ahead and revert it, then -- but the revert
will restore some comment confetti that's pretty outdated that we want
to get rid of.
--js
