On 9/25/19 4:03 PM, Tomáš Golembiovský wrote:
Add command for reporting devices on Windows guest. The intent is not so
much to report the devices but more importantly the driver (and its
version) that is assigned to the device. This gives caller the
information whether VirtIO drivers are installed and/or whether
inadequate driver is used on a device (e.g. QXL device with base VGA
driver).
Signed-off-by: Tomáš Golembiovský <tgole...@redhat.com>
---
It's nice to mention here, after the --- separator, how v4 differs from
earlier versions, to let reviewers that saw the earlier version check
the differences.
+++ b/qga/qapi-schema.json
@@ -1242,3 +1242,35 @@
##
{ 'command': 'guest-get-osinfo',
'returns': 'GuestOSInfo' }
+
+##
+# @GuestDeviceInfo:
+#
+# @vendor-id: vendor ID
+# @device-id: device ID
+# @driver-name: name of the associated driver
+# @driver-date: driver release date in format YYYY-MM-DD
+# @driver-version: driver version
+#
+# Since: 4.2
+##
+{ 'struct': 'GuestDeviceInfo',
+ 'data': {
+ 'vendor-id': 'uint16',
+ 'device-id': 'uint16',
+ 'driver-name': 'str',
+ 'driver-date': 'str',
+ 'driver-version': 'str'
+ } }
+
+##
+# @guest-get-devices:
+#
+# Retrieve information about device drivers in Windows guest
+#
+# Returns: @GuestDeviceInfo
+#
+# Since: 4.2
+##
+{ 'command': 'guest-get-devices',
+ 'returns': ['GuestDeviceInfo'] }
I'm not spotting any obvious problems with the interface itself, but am
not comfortable enough with the rest of the code for a full review.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
