On Wed, Sep 25, 2019 at 04:28:58PM +0100, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 25/09/19 15:13, Dr. David Alan Gilbert wrote: > > > * Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > > >> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > >> > > >> This patch uses glib's g_auto mechanism to automatically free > > >> rcu_read_lock's at the end of the block. Given that humans > > >> have a habit of forgetting an error path somewhere it's > > >> best to leave it to the compiler. > > > > > > I've had to unqueue this - clang doesn't like the apparently unused > > > auto variable; we need to find a way to make that happy. > > > > __attribute__((unused))? > > I worry that if I do that, then it'll optimise it out.
Can you just insert a dummy use of the variable. eg libvirt does this by just taking the address of the unused variable and casting the result to void. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
