Eric Blake <ebl...@redhat.com> writes: > On 9/24/19 8:28 AM, Markus Armbruster wrote: >> We track source locations with a dict of the form >> >> {'file': FNAME, 'line': LINENO, parent': PARENT} > > Missing ' on parent > >> >> where PARENT is None for the main file, and the include directive's >> source location for included files. >> >> This is servicable enough, but the next commit will add information, > > serviceable
Will fix both. >> and that's going to come out cleaner if we turn this into a class. So >> do that. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> scripts/qapi/common.py | 69 +++++++++++++++++++++++++----------------- >> 1 file changed, 41 insertions(+), 28 deletions(-) >> > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks!