On 9/24/19 8:28 AM, Markus Armbruster wrote: > qap-gen.py crashes when it can't open the main schema file, and when
qapi-gen.py > it can't read from any schema file. Lazy. > > Change QAPISchema.__init__() to take a file name instead of a file > object. Move the open code from _include() to __init__(), so it's > used for the main schema file, too. > > Move the read into the try for good measure, and rephrase the error > message. > > Reporting open or read failure for the main schema file needs a > QAPISourceInfo representing "no source". Make QAPISourceInfo cope > with fname=None. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > scripts/qapi/common.py | 46 +++++++++++++++------------ > tests/qapi-schema/include-no-file.err | 2 +- > 2 files changed, 27 insertions(+), 21 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
