On Fri, Sep 20, 2019 at 3:48 PM Palmer Dabbelt <pal...@sifive.com> wrote: > > On Tue, 17 Sep 2019 16:22:56 PDT (-0700), Alistair Francis wrote: > > The do_unassigned_access hook has been deprecated and RISC-V is the last > > user of it. Let's instead update the RISC-V implementation to use > > do_transaction_failed instead. > > > > After this series I used the 'git grep' regexes in > > docs/devel/loads-stores.rst and these are the memory accesses inside > > target/riscv: > > > > monitor.c:102: cpu_physical_memory_read(pte_addr, &pte, ptesize); > > > > cpu_helper.c:262: target_ulong pte = address_space_ldl(cs->as, > > pte_addr, attrs, &res); > > cpu_helper.c:264: target_ulong pte = address_space_ldq(cs->as, > > pte_addr, attrs, &res); > > > > translate.c:782: ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next); > > > > gdbstub.c:328: env->fpr[n] = ldq_p(mem_buf); /* always 64-bit */ > > > > All of these look safe to me. > > > > Palmer Dabbelt (2): > > RISC-V: Handle bus errors in the page table walker > > RISC-V: Implement cpu_do_transaction_failed > > Can you Reviewed-By these, as they've still got my Author on them? That way I > can pull them in :)
Richard and Philippe have both reviewed it, that should be enough. I'm not sure if I can review it with my SOB as well. Alistair > > > > > target/riscv/cpu.c | 2 +- > > target/riscv/cpu.h | 7 +++++-- > > target/riscv/cpu_helper.c | 23 ++++++++++++++++------- > > 3 files changed, 22 insertions(+), 10 deletions(-)
