On 23/09/19 18:05, Richard Henderson wrote: > On 9/23/19 1:52 AM, David Hildenbrand wrote: >>> - tb_invalidate_phys_page_range__locked(pages, p, start, end, >>> - is_cpu_write_access); >>> + tb_invalidate_phys_page_range__locked(pages, p, start, end, 0); >> >> I'd prefer "false" to highlight the semantics, but as it's and int ... >> >> Reviewed-by: David Hildenbrand <da...@redhat.com> > > I did think of that, but then the next patch changes this last argument to > "uintptr_t retaddr", so then it's not really a boolean argument anymore, and > "0" is exactly what we want.
Yeah, 0 is fine here. Paolo
